[Scummvm-tracker] [ScummVM :: Bugs] #11435: Macintosh Space Quest 1 VGA Remake: broken music

[ScummVM :: Bugs]

#11435: Macintosh Space Quest 1 VGA Remake: broken music
----------------------------+-----------------------------------
  Reporter:  vanfanel       |      Owner:  (none)
      Type:  defect         |     Status:  new
  Priority:  normal         |  Component:  Engine: SCI
Resolution:                 |   Keywords:  Macintosh, SCI, music
      Game:  Space Quest 1  |
----------------------------+-----------------------------------
Comment (by ZvikaZ):

 Well, you guys did an amazing work. Starting from investigating Sierra's
 SCI, building FreeSCI, and ScummVM's SCI engine.
 It's really huge.
 And IMO, it's better than what you think ;-)

 I've started to learn and investigate the SCI sound bugs few months ago,
 and the situation (again, IMO) is very good.
 I contributed few fixes, that aren't specific band-aid type, but catching
 some small general case mismatches.

 Please let me give a short overview of the recent sound bug fixes, and the
 remaining sound bugs still open:

 https://github.com/scummvm/scummvm/pull/2074 fixed:
 https://bugs.scummvm.org/ticket/6686 (General MIDI using SC-55 misses
 instruments) that was opened for 6 years,
 https://bugs.scummvm.org/ticket/9578 (SQ6 wrong volume) that was opened
 for 3 years,
 https://bugs.scummvm.org/ticket/9735 (GK1 missing score jingle) that was
 opened for 3 years,
 https://bugs.scummvm.org/ticket/10297 (QFG1VGA: Wrong instruments),
 https://bugs.scummvm.org/ticket/11012 (MIDI volume is not reduced when
 character voices are speaking)

 https://github.com/scummvm/scummvm/pull/2146 fixed
 https://bugs.scummvm.org/ticket/7073 (KQ6-CD: Savegame that cannot be
 resumed - but it's due to sound problem) that was open for 4 years and
 https://bugs.scummvm.org/ticket/10685 (GK1 music issue on restore)

 https://github.com/scummvm/scummvm/pull/2149 fixed
 https://bugs.scummvm.org/ticket/9907 (LB1: Sound effect not playing when
 discovering corpse)

 https://github.com/scummvm/scummvm/pull/2182 fixed
 https://bugs.scummvm.org/ticket/11409 (not-emulated-SC problems, in KQ6
 and GK1)

 Indeed, I closed https://bugs.scummvm.org/ticket/5115 (Missing instruments
 in Jones) and https://bugs.scummvm.org/ticket/6165 (Pepper: Hanging note)
 without applying fixes, because I didn't hear any problem, the user hasn't
 responded to questions, and they were probably fixed by some sound change
 in the passing years.

 There are 2 PRs that fix more bugs, and need to be reviewed:

 https://github.com/scummvm/scummvm/pull/2128 (which @bluegr started
 reviewing, but stopped - it'd be great if someone can review this...) will
 fix:
 https://bugs.scummvm.org/ticket/10812 (KQ6CD wallflower dance music not
 restarting, leads to lockup), https://bugs.scummvm.org/ticket/10907 (Wrong
 music when restoring games) and unreported bug (restoring restarts the
 playing music from the beginning)

 https://github.com/scummvm/scummvm/pull/2165 is the only sound fix that I
 saw that's of the local band-aid kind - for one of the issues described at
 https://bugs.scummvm.org/ticket/11265 (SQ4 audio problem), but I think
 it's due to Sierra's SCI bug, as I wrote inside the PR.


 So, what's still open?

 https://bugs.scummvm.org/ticket/5307 (PQ3: channel volumes are wrong when
 using Adlib) - I'm not sure that it's still relevant, as I wrote there.
 https://bugs.scummvm.org/ticket/6687 (Quitting while MIDI plays causes
 hanging notes) - I have suggested a fix, but waiting for someone to verify
 it, as I don't have the hardware...
 https://bugs.scummvm.org/ticket/9579 (Music volume at zero still plays
 music very softly) - not really a bug, but a reminder
 https://bugs.scummvm.org/ticket/9580 (GK2: Improve bad AV sync in GK2
 VMDs)
 https://bugs.scummvm.org/ticket/9803 (SQ6: Quiet music on loading save
 game) - should be fixed by the accepted PR #2074
 https://bugs.scummvm.org/ticket/10734 (LB1: Turn-crank and open-vault
 sound fx not playing)
 https://bugs.scummvm.org/ticket/11049 (Circus quest - no sound) - I'm not
 sure that it's a ScummVM bug (as I wrote there)
 https://bugs.scummvm.org/ticket/11265 (SQ4 audio problem) - I'm working on
 it - the aforementioned PR #2165, and it needs more work that I plan to do
 after the PR will be accepted.
 https://bugs.scummvm.org/ticket/11354 (CASTLEBRAIN: Stereo audio flipped
 in hourglass puzzle) - I understood the problem, but not sure what's the
 best way to fix it - wrote about it in the bug - comments are welcomed!
 https://bugs.scummvm.org/ticket/11435 (this bug...)

 lighthouse also has few "sound" problems, but according to the bug reports
 they are due to script bugs, and not sound system bugs.

 So, bottom line, we had several old bugs that were fixed, 2 PRs waiting to
 be reviewed, and we have very small (reported) issues left after that,
 none of them requiring massive rewrites of the sound system.

 "If I have seen further it is by standing on the shoulders of Giants."
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/11435#comment:8>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM