[Scummvm-tracker] [ScummVM :: Bugs] #10931: SHERLOCK: SCALPEL: Nobby Charleton won't talk to Sherlock

[ScummVM :: Bugs]

#10931: SHERLOCK: SCALPEL: Nobby Charleton won't talk to Sherlock
-------------------------+-------------------------------------------------
Reporter:  ignaciojn     |       Owner:  dreammaster
    Type:  defect        |      Status:  new
Priority:  normal        |   Component:  Engine: Sherlock
 Version:                |  Resolution:
Keywords:                |        Game:  Sherlock Holmes: Case of the
                         |  Serrated Scalpel
-------------------------+-------------------------------------------------
Comment (by eriktorbjorn):

 I'm a bit vague about the details, but I think there's a problem with the
 way it pushes/pulls sequences from the stack.

 When a conversation is initiated, Talk::initTalk() clears the sequence
 stack and pushes a new sequence on it. I think this is the animation the
 character was doing before you started talking to him.

 Then ScalpelTalk::showTalk() clears the stack and pushes a sequence
 ''again''. But this time, it's probably the animation for the character
 standing still while you're talking to him.

 If character portraits are enabled, there's a push and a pull probably
 related to the portrait animation.

 When the conversation is done, the sequence is pulled from the stack. But
 it's probably the one that ScalpelTalk::showTalk() pushed, so it doesn't
 restart the old animation.

 I have a feeling that ScalpelTalk::showTalk() shouldn't clear and push to
 the sequence stack. But I'm not 100% sure, and I can't look further right
 now.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/10931#comment:14>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM