[Scummvm-tracker] [ScummVM :: Bugs] #11758: PEGASUS: colossal memory leak, wan't start

[ScummVM :: Bugs]

#11758: PEGASUS: colossal memory leak, wan't start
-----------------------+-----------------------------------------------
Reporter:  fedor4ever  |       Owner:  sev-
    Type:  defect      |      Status:  new
Priority:  high        |   Component:  Engine: Pegasus
 Version:              |  Resolution:
Keywords:              |        Game:  Journeyman Project Pegasus Prime
-----------------------+-----------------------------------------------
Comment (by criezy):

 Thank you for taking the time to look into this further.

 This is possibly a regression from
 https://github.com/scummvm/scummvm/commit/1bb7386?
 Since it is a simple and short commit, could you try to revert that change
 locally to see if that fixes the issue for you?


 {{{
 --- a/common/macresman.cpp
 +++ b/common/macresman.cpp
 @@ -317,10 +317,10 @@ bool MacResManager::isMacBinary(SeekableReadStream
 &stream) {

                 uint32 dataSizePad = (((dataSize + 127) >> 7) << 7);
                 // Files produced by ISOBuster are not padded, thus,
 compare with the actual size
 -               //uint32 rsrcSizePad = (((rsrcSize + 127) >> 7) << 7);
 +               uint32 rsrcSizePad = (((rsrcSize + 127) >> 7) << 7);

                 // Length check
 -               if (MBI_INFOHDR + dataSizePad + rsrcSize <=
 (uint32)stream.size()) {
 +               if (MBI_INFOHDR + dataSizePad + rsrcSizePad ==
 (uint32)stream.size()) {
                         resForkOffset = MBI_INFOHDR + dataSizePad;
                 }
         }
 }}}
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/11758#comment:15>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM