[Scummvm-tracker] [ScummVM :: Bugs] #11758: PEGASUS: colossal memory leak, wan't start

ScummVM :: Bugs trac at scummvm.org
Sun Feb 21 22:34:01 UTC 2021


#11758: PEGASUS: colossal memory leak, wan't start
-----------------------+-----------------------------------------------
Reporter:  fedor4ever  |       Owner:  sev-
    Type:  defect      |      Status:  new
Priority:  high        |   Component:  Engine: Pegasus
 Version:              |  Resolution:
Keywords:              |        Game:  Journeyman Project Pegasus Prime
-----------------------+-----------------------------------------------
Comment (by fedor4ever):

 Replying to [comment:15 criezy]:
 > Thank you for taking the time to look into this further.
 >
 > This is possibly a regression from
 https://github.com/scummvm/scummvm/commit/1bb7386?
 > Since it is a simple and short commit, could you try to revert that
 change locally to see if that fixes the issue for you?
 >
 > Here is the change to try:
 >
 > {{{
 > --- a/common/macresman.cpp
 > +++ b/common/macresman.cpp
 > @@ -317,10 +317,10 @@ bool MacResManager::isMacBinary(SeekableReadStream
 &stream) {
 >
 >                 uint32 dataSizePad = (((dataSize + 127) >> 7) << 7);
 >                 // Files produced by ISOBuster are not padded, thus,
 compare with the actual size
 > -               //uint32 rsrcSizePad = (((rsrcSize + 127) >> 7) << 7);
 > +               uint32 rsrcSizePad = (((rsrcSize + 127) >> 7) << 7);
 >
 >                 // Length check
 > -               if (MBI_INFOHDR + dataSizePad + rsrcSize <=
 (uint32)stream.size()) {
 > +               if (MBI_INFOHDR + dataSizePad + rsrcSizePad ==
 (uint32)stream.size()) {
 >                         resForkOffset = MBI_INFOHDR + dataSizePad;
 >                 }
 >         }
 > }}}

 It works for symbian!!! try for windows tomorrow =)
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/11758#comment:16>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM


More information about the Scummvm-tracker mailing list