[Scummvm-tracker] [ScummVM :: Bugs] #12057: TWINE: Crash near ferry

[ScummVM :: Bugs]

#12057: TWINE: Crash near ferry
-------------------+-----------------------------------
Reporter:  vvs-    |       Owner:  (none)
    Type:  defect  |      Status:  new
Priority:  normal  |   Component:  Engine: TwinE
 Version:          |  Resolution:
Keywords:          |        Game:  Little Big Adventure
-------------------+-----------------------------------
Comment (by mgerhardy):

 It most likely depends on the location of the text bubble on the screen.
 Is this a release build? I'm asking because there should be an assert to
 catch a potential error in copyBlockPhys() already. This it looks like
 this isn't triggered.

 It looks suspicious, that we are validating a different rect in
 Redraw::drawBubble than we sending over to the copyBlockPhys call.

 Talking about:

         if (_engine->_interface->textWindow.left <=
 _engine->_interface->textWindow.right &&
 _engine->_interface->textWindow.top <=
 _engine->_interface->textWindow.bottom) {
                 _engine->copyBlockPhys(renderRect, true);
         }


 should maybe be

         if (renderRect.left <= renderRect.right && renderRect.top <=
 renderRect.bottom) {
                 _engine->copyBlockPhys(renderRect, true);
         }
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/12057#comment:2>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM