[Scummvm-tracker] [ScummVM :: Bugs] #12900: BURIED: My CD version (v1.00 24BPP/Windows/English) crashes on startup

[ScummVM :: Bugs]

#12900: BURIED: My CD version (v1.00 24BPP/Windows/English) crashes on startup
-------------------------------------------------+-------------------------
Reporter:  eriktorbjorn                          |      Owner:  (none)
    Type:  defect                                |     Status:  new
Priority:  normal                                |  Component:  Engine:
                                                 |  Buried
 Version:                                        |   Keywords:
    Game:  Journeyman Project 2: Buried in Time  |
-------------------------------------------------+-------------------------
 I have two different versions of Journeyman Project 2: Buried in Time. One
 is on DVD and is identified as either "v1.1 8BPP/Windows/English" or "v1.1
 24BPP/Windows/English". These appear to work fine, from what little I've
 tried them.

 I also have a CD version, which is identified as either "v1.00
 8BPP/Windows/English" or "v1.00 24BPP/Windows/English". The 8BPP version
 starts and seems to run fine. But the 24BPP version crashes on startup.

 Running it with Valgrind produced the following error log:

 {{{
 ==967777== Invalid write of size 1
 ==967777==    at 0x3ED15D1:
 Common::WinResources::loadFromCompressedEXE(Common::String const&)
 (winexe.cpp:151)
 ==967777==    by 0x112A819: Buried::BuriedEngine::run() (buried.cpp:109)
 ==967777==    by 0x9183D6: runGame(Plugin const*, Plugin const*, OSystem&,
 Common::String const&) (main.cpp:311)
 ==967777==    by 0x919CBF: scummvm_main (main.cpp:618)
 ==967777==    by 0x9158E6: main (posix-main.cpp:45)
 ==967777==  Address 0x26cf2b30 is 0 bytes after a block of size 1,162,752
 alloc'd
 ==967777==    at 0x6CCB7B5: malloc (in /usr/libexec/valgrind
 /vgpreload_memcheck-amd64-linux.so)
 ==967777==    by 0x3ED1483:
 Common::WinResources::loadFromCompressedEXE(Common::String const&)
 (winexe.cpp:130)
 ==967777==    by 0x112A819: Buried::BuriedEngine::run() (buried.cpp:109)
 ==967777==    by 0x9183D6: runGame(Plugin const*, Plugin const*, OSystem&,
 Common::String const&) (main.cpp:311)
 ==967777==    by 0x919CBF: scummvm_main (main.cpp:618)
 ==967777==    by 0x9158E6: main (posix-main.cpp:45)
 ==967777==
 ==967777== Invalid write of size 1
 ==967777==    at 0x3ED15D1:
 Common::WinResources::loadFromCompressedEXE(Common::String const&)
 (winexe.cpp:151)
 ==967777==    by 0x112A8DB: Buried::BuriedEngine::run() (buried.cpp:112)
 ==967777==    by 0x9183D6: runGame(Plugin const*, Plugin const*, OSystem&,
 Common::String const&) (main.cpp:311)
 ==967777==    by 0x919CBF: scummvm_main (main.cpp:618)
 ==967777==    by 0x9158E6: main (posix-main.cpp:45)
 ==967777==  Address 0x28b47640 is 0 bytes after a block of size 5,211,648
 alloc'd
 ==967777==    at 0x6CCB7B5: malloc (in /usr/libexec/valgrind
 /vgpreload_memcheck-amd64-linux.so)
 ==967777==    by 0x3ED1483:
 Common::WinResources::loadFromCompressedEXE(Common::String const&)
 (winexe.cpp:130)
 ==967777==    by 0x112A8DB: Buried::BuriedEngine::run() (buried.cpp:112)
 ==967777==    by 0x9183D6: runGame(Plugin const*, Plugin const*, OSystem&,
 Common::String const&) (main.cpp:311)
 ==967777==    by 0x919CBF: scummvm_main (main.cpp:618)
 ==967777==    by 0x9158E6: main (posix-main.cpp:45)
 ==967777==
 }}}

 I assume that the .ex_ and/or .dl_ files are compressed, and that there is
 something not quite working about the decompresser.

 When running in Valgrind, ScummVM no longer crashes for me, so I was able
 to tell that there are errors both when reading BIT2416.EX_ and
 BIT24LIB.DL_.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/12900>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM