[Scummvm-tracker] [ScummVM :: Bugs] #12901: SCI: PQ4 (CD): German CD Version crash when entering the options in the game (was: Police quest IV German CD Version crash when entering the options in the game)

[ScummVM :: Bugs]

#12901: SCI: PQ4 (CD): German CD Version crash when entering the options in the
game
--------------------------------------------+-----------------------------
Reporter:  gabberhead                       |       Owner:  (none)
    Type:  defect                           |      Status:  new
Priority:  high                             |   Component:  Engine: SCI
 Version:                                   |  Resolution:
Keywords:  crash, patcher, high resolution  |        Game:  Police Quest 4
--------------------------------------------+-----------------------------
Changes (by antoniou79):

 * keywords:  crash => crash, patcher, high resolution
 * summary:
     Police quest IV German CD Version crash when entering the options in
     the game
     =>
     SCI: PQ4 (CD): German CD Version crash when entering the options in
     the game

Comment:

 I'm adding my comment from the forum thread, in case it might be helpful:
 With the kDebugLevelGraphics enabled, the output at the error mark is:
  kAddScreenItem 36:1e92 (iconText)
  Failed to load mem 0000:0000!
 This is triggered in ScreenItem::setFromObject() (screen_item32.cpp)
 https://github.com/scummvm/scummvm/blob/2d50ec4a412b9c807cc305679bbd8df979c56861/engines/sci/graphics/screen_item32.cpp#L172

 By (crudely) removing the the applyPatch() line in script_patches.cpp, the
 error no longer happens, but then the PQ4 patch for subtitles+audio option
 in the GUI is no longer functional.
 https://github.com/scummvm/scummvm/blob/2d50ec4a412b9c807cc305679bbd8df979c56861/engines/sci/engine/script_patches.cpp#L22233

 So the error is related to the patch application, which does not seem to
 "agree" with the DEU version.

 I don't know why it is connected to the "high resolution" engine option
 though.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/12901#comment:1>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM