[Scummvm-tracker] [ScummVM :: Bugs] #12345: BASE: The detection plugin is almost always loaded in memory

ScummVM :: Bugs trac at scummvm.org
Sun Sep 19 08:30:16 UTC 2021


#12345: BASE: The detection plugin is almost always loaded in memory
------------------------+------------------------
Reporter:  ccawley2011  |       Owner:  (none)
    Type:  defect       |      Status:  new
Priority:  normal       |   Component:  --Unset--
 Version:               |  Resolution:
Keywords:               |        Game:
------------------------+------------------------
Comment (by Die4Ever):

 also, in the AdvancedMetaEngineDetection constructor I did this

 {{{
     for (const byte *descPtr = _gameDescriptors; 1; descPtr +=
 _descItemSize) {
         total_size += _descItemSize;
         auto p = (const ADGameDescription *)descPtr;
         for (auto f : p->filesDescriptions) {
             if (f.fileName)
                 total_size += strlen(f.fileName) + 1;
             if (f.md5)
                 total_size += strlen(f.md5) + 1;
         }
         if(p->extra)
             total_size += strlen(p->extra)+1;
         if(p->gameId)
             total_size += strlen(p->gameId)+1;

         if (p->gameId == nullptr)
             break;
     }
     total_size += sizeof(AdvancedMetaEngineDetection);
 }}}
 total_size was 3,635,964 bytes, without the strlens it was still 2,962,304
 bytes
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/12345#comment:2>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM


More information about the Scummvm-tracker mailing list