[Scummvm-tracker] [ScummVM :: Bugs] #7073: KQ6-CD: Savegame that cannot be resumed

[ScummVM :: Bugs]

#7073: KQ6-CD: Savegame that cannot be resumed
-------------------------+-----------------------------
Reporter:  SF/fiesh8192  |       Owner:  sluicebox
    Type:  defect        |      Status:  closed
Priority:  normal        |   Component:  Engine: SCI
 Version:                |  Resolution:  fixed
Keywords:                |        Game:  King's Quest 6
-------------------------+-----------------------------
Changes (by sluicebox):

 * owner:  ZvikaZ => sluicebox
 * status:  new => closed
 * resolution:   => fixed

Comment:

 Fixed in:
 https://github.com/scummvm/scummvm/commit/6e5b1e31f0f9672cb979a7fa12d4bed35a4f6bf1

 This bug was due to not including the `MusicEntry::fadeCompleted` flag in
 save files.

 horseToon fades out sound 155 over 1.16 seconds and waits on the fade to
 complete in handsOff mode. Saving during this fade means going to the icon
 bar, bringing up the control panel, and then clicking save. That takes
 more than 1.16 seconds and so the fade would complete while the game's UI
 was displayed and the game was paused. At this point, ScummVM's fade timer
 has set `MusicEntry::fadeCompleted` to tell
 `SoundCommand::processUpdateCues()` to signal the Sound object. Cues
 aren't processed until the UI is closed and the game resumes. By not
 saving `fadeCompleted`, it was reset to false upon loading, and
 `processUpdateCues()` never learned that the fade had already completed
 before the save. The script was then stuck waiting to be cued.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/7073#comment:13>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM