[Scummvm-tracker] [ScummVM :: Bugs] #13546: LSL6: Games may restore with muted music or broken volume fade-out

[ScummVM :: Bugs]

#13546: LSL6: Games may restore with muted music or broken volume fade-out
-------------------------------+-----------------------------------
Reporter:  RayKoopa            |       Owner:  sluicebox
    Type:  defect              |      Status:  closed
Priority:  normal              |   Component:  Engine: SCI
 Version:                      |  Resolution:  fixed
Keywords:  music, audio, save  |        Game:  Leisure Suit Larry 6
-------------------------------+-----------------------------------
Changes (by sluicebox):

 * owner:  (none) => sluicebox
 * status:  new => closed
 * resolution:   => fixed

Comment:

 Fixing #7073 fixes this, at least the part I was able to reproduce:
 https://github.com/scummvm/scummvm/commit/6e5b1e31f0f9672cb979a7fa12d4bed35a4f6bf1

 The problem occurs when a fade completes while you have the menu open and
 then you click Save.

 One way to reproduce:
 - Walk from the pool into the hotel
 - Open the menu during the music fade and keep it open until the fade is
 finished (very low volume)
 - Click the Save menu item and save the game
 - New music will start at expected volume (it was waiting for the game to
 unpause)
 - Load the save
 - Previous room's music is at very low volume and stays that way

 The fix was to include some missing sound data in the save files. Only new
 saves will be fixed. This changes the save game format (they have version
 numbers) so SCI saves created after this commit won't be usable by
 versions of ScummVM before the commit. Old saves can still be used by the
 newer version.

 Please test this when you have a chance. Thanks!
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/13546#comment:4>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM