[Scummvm-tracker] [ScummVM :: Bugs] #13378: SCUMM: SAMNMAX: Timing Problems in German CD Intro

[ScummVM :: Bugs]

#13378: SCUMM: SAMNMAX: Timing Problems in German CD Intro
-------------------------+----------------------------
Reporter:  GermanTribun  |       Owner:  (none)
    Type:  defect        |      Status:  new
Priority:  normal        |   Component:  Engine: SCUMM
 Version:                |  Resolution:
Keywords:                |        Game:  Sam and Max
-------------------------+----------------------------
Comment (by eriktorbjorn):

 The scripts have a lot of differences between the localized versions,
 probably to get the animation to sync better with the speech.

 That said, the lowest the English version ever sets VAR_TIMER_NEXT to is
 3, and that's for when Max says "This doesn't look like the Lincoln
 Tunnel, Sam."

 The outliers are

 * The German version sets it to 1 for "You'll fry like a pork sausage!"
 Suppressing this would leave it at 6, same as the English version
 * The Italian version sets it to 2 when Max beats up the scientist. I
 guess it was sped up to match the subtitles better, but the animation
 looks weird. Suppressing this would leave it at 6, same as the English
 version.

 So that gives the following revised workaround:

 {{{
 diff --git a/engines/scumm/script.cpp b/engines/scumm/script.cpp
 index f763b967056..0bc6931ccdc 100644
 --- a/engines/scumm/script.cpp
 +++ b/engines/scumm/script.cpp
 @@ -648,6 +648,24 @@ void ScummEngine::writeVar(uint var, int value) {
                         }
                 }

 +               // WORKAROUND bug #13378: For whatever reason, the German
 and
 +               // Italian talkie versions (I can't check the floppy
 versions)
 +               // set the game to run much too fast in some parts of the
 intro.
 +               // Some differences are natural because of the different
 lengths
 +               // of the spoken lines, but 1 or 2 is too fast.
 +
 +               if (_game.id == GID_SAMNMAX &&
 vm.slot[_currentScript].number == 65 && _enableEnhancements) {
 +                       // "Wirst Du brutzeln, wie eine grobe Bratwurst!"
 +                       if (value == 1 && _language == Common::DE_DEU)
 +                               return;
 +
 +                       // Max beats up the scientist. This was probably
 to
 +                       // match the subtitles to the speech better, but
 it
 +                       // makes the animation look strange.
 +                       if (value == 2 && _language == Common::IT_ITA)
 +                               return;
 +               }
 +
 }}}
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/13378#comment:7>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM