[Scummvm-tracker] [ScummVM :: Bugs] #13918: SCUMM: MI1 Playback Adjustment settings hide Original GUI setting

[ScummVM :: Bugs]

#13918: SCUMM: MI1 Playback Adjustment settings hide Original GUI setting
----------------------------+---------------------------
Reporter:  dwatteau         |      Owner:  (none)
    Type:  defect           |     Status:  new
Priority:  normal           |  Component:  Engine: SCUMM
 Version:                   |   Keywords:  game settings
    Game:  Monkey Island 1  |
----------------------------+---------------------------
 Current Git 83ff98940d6d2 HEAD on macOS.

 MI1 CD has an `original_gui` option, but it's the only version of Monkey1
 where you can't change this setting from our interface (but it's there in
 the config file), possibly because the `mi1_intro_adjustment` and
 `mi1_outlook_adjustment` settings "hide" it.

 `enable_enhancements` is there, though.

 I think this is probably related to this part of dialogs.cpp:
 {{{
 // Game options widgets

 // Normally this would be added as a static game settings widget, but I
 see no
 // way to get both the dynamic and the static one, so we have to duplicate
 it
 // here.

 GUI::CheckboxWidget
 *ScummOptionsContainerWidget::createEnhancementsCheckbox(GuiObject *boss,
 const Common::String &name) {
         return new GUI::CheckboxWidget(boss, name, _("Enable game-specific
 enhancements"), _("Allow ScummVM to make small enhancements to the game,
 usually based on other versions of the same game."));
 }
 }}}

 i.e. we probably just need to duplicate `original_gui` there, too.

 Problem is that whenever we add a new game setting to the SCUMM engine, it
 will need to be duplicated there as well for MI1, and Loom (which has a
 similar playback adjustment setting). So I don't know if that's what we
 want to do, in terms of code maintenance.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/13918>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM