[Scummvm-tracker] [ScummVM :: Bugs] #13918: SCUMM: MI1 Playback Adjustment settings hide Original GUI setting
ScummVM :: Bugs
trac at scummvm.org
Sat Nov 5 08:18:21 UTC 2022
#13918: SCUMM: MI1 Playback Adjustment settings hide Original GUI setting
--------------------------+------------------------------
Reporter: dwatteau | Owner: (none)
Type: defect | Status: new
Priority: normal | Component: Engine: SCUMM
Version: | Resolution:
Keywords: game settings | Game: Monkey Island 1
--------------------------+------------------------------
Comment (by eriktorbjorn):
For reference, this is the part of gui/editgamedialog.cpp that I think is
responsible for allowing either a "static" or a "dynamic" settings widget,
but not both at the same time:
{{{
//
// 2) The engine's game settings (shown only if the engine
implements one or there are custom engine options)
//
if (metaEnginePlugin) {
const MetaEngineDetection &metaEngineDetection =
metaEnginePlugin->get<MetaEngineDetection>();
metaEngineDetection.registerDefaultSettings(_domain);
if (enginePlugin) {
enginePlugin->get<MetaEngine>().registerDefaultSettings(_domain);
_engineOptions =
enginePlugin->get<MetaEngine>().buildEngineOptionsWidgetDynamic(tab,
"GameOptions_Game.Container", _domain);
}
if (!_engineOptions)
_engineOptions =
metaEngineDetection.buildEngineOptionsWidgetStatic(tab,
"GameOptions_Game.Container", _domain);
if (_engineOptions) {
_engineOptions->setParentDialog(this);
}
}
}}}
--
Ticket URL: <https://bugs.scummvm.org/ticket/13918#comment:1>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM
More information about the Scummvm-tracker
mailing list