[Scummvm-tracker] [ScummVM :: Bugs] #15457: KQ7: Odd behavior for disabling subtitles

[ScummVM :: Bugs]

#15457: KQ7: Odd behavior for disabling subtitles
-----------------------+-----------------------------
Reporter:  antoniou79  |       Owner:  (none)
    Type:  defect      |      Status:  new
Priority:  normal      |   Component:  Engine: SCI
 Version:              |  Resolution:
Keywords:              |        Game:  King's Quest 7
-----------------------+-----------------------------
Comment (by eriktorbjorn):

 I went back to a much earlier version, and there it worked. I then tried
 bisecting for a bit. Here's one point where it broke:

 {{{
 25401cdf922ca629d8e6c8d8664a07b0c755b897 is the first bad commit
 commit 25401cdf922ca629d8e6c8d8664a07b0c755b897
 Author: Filippos Karapetis <bluegr at gmail.com>
 Date:   Thu Jun 30 17:14:35 2022 +0300

     GUI: Add missing domain when checking for subtitle config - bug #13629

     This disallowed selecting "both" for speech and subtitles, as the
     subtitles setting was never saved. A regression from d6dbf721b62e773f.

  gui/options.cpp | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 }}}

 I don't know if this is the only point. I deliberately bisected a very
 small interval, because I had a hunch that it would break here.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15457#comment:5>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM