[Scummvm-tracker] [ScummVM :: Bugs] #15457: KQ7: Odd behavior for disabling subtitles

[ScummVM :: Bugs]

#15457: KQ7: Odd behavior for disabling subtitles
-----------------------+-----------------------------
Reporter:  antoniou79  |       Owner:  (none)
    Type:  defect      |      Status:  new
Priority:  normal      |   Component:  Engine: SCI
 Version:              |  Resolution:
Keywords:              |        Game:  King's Quest 7
-----------------------+-----------------------------
Comment (by eriktorbjorn):

 Originally, it would always write both `"subtitles"` and `"speech_mute"`
 to the config manager, like so:

 {{{
 ConfMan.setBool("subtitles", subtitles, _domain);
 ConfMan.setBool("speech_mute", speech_mute, _domain);
 }}}

 This was changed in
 https://github.com/scummvm/scummvm/commit/d6dbf721b62e773f529276f5b1c0c3ce59df6f47
 ("ALL: add support for --subtitles") to this:

 {{{
 if (subtitles != ConfMan.getBool("subtitles")) {
         ConfMan.setBool("subtitles", subtitles, _domain);
 _subToggleDesc->setFontColor(ThemeEngine::FontColor::kFontColorNormal);
 }
 ConfMan.setBool("speech_mute", speech_mute, _domain);
 }}}

 And then, finally,
 https://github.com/scummvm/scummvm/commit/25401cdf922ca629d8e6c8d8664a07b0c755b897
 ("GUI: Add missing domain when checking for subtitle config - bug #13629")
 changed it to:

 {{{
 if (subtitles != ConfMan.getBool("subtitles", _domain)) {
         ConfMan.setBool("subtitles", subtitles, _domain);
 _subToggleDesc->setFontColor(ThemeEngine::FontColor::kFontColorNormal);
 }
 ConfMan.setBool("speech_mute", speech_mute, _domain);
 }}}

 I'm not sure I understand even the first change here. Maybe @sev knows?
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15457#comment:6>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM