[Scummvm-tracker] [ScummVM :: Bugs] #15457: KQ7: Odd behavior for disabling subtitles

[ScummVM :: Bugs]

#15457: KQ7: Odd behavior for disabling subtitles
-----------------------+-----------------------------
Reporter:  antoniou79  |       Owner:  (none)
    Type:  defect      |      Status:  new
Priority:  normal      |   Component:  Engine: SCI
 Version:              |  Resolution:
Keywords:              |        Game:  King's Quest 7
-----------------------+-----------------------------
Comment (by eriktorbjorn):

 This is a tempting change to make, but I don't know if I'm on the right
 track:

 {{{
 diff --git a/gui/options.cpp b/gui/options.cpp
 index d000413fae8..b586d17cae9 100644
 --- a/gui/options.cpp
 +++ b/gui/options.cpp
 @@ -1086,7 +1086,7 @@ void OptionsDialog::apply() {
                                         break;
                                 }

 -                               if (subtitles !=
 ConfMan.getBool("subtitles", _domain)) {
 +                               if (!ConfMan.hasKey("subtitles", _domain)
 || subtitles != ConfMan.getBool("subtitles", _domain)) {
                                         ConfMan.setBool("subtitles",
 subtitles, _domain);
 _subToggleDesc->setFontColor(ThemeEngine::FontColor::kFontColorNormal);
                                 }
 }}}
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15457#comment:7>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM