[Scummvm-tracker] [ScummVM :: Bugs] #15724: SCUMM: Sam and Max: Speech garbled and extremely slowed down

[ScummVM :: Bugs]

#15724: SCUMM: Sam and Max: Speech garbled and extremely slowed down
--------------------------+----------------------------
Reporter:  raziel-        |       Owner:  NMIError
    Type:  defect         |      Status:  closed
Priority:  normal         |   Component:  Engine: SCUMM
 Version:                 |  Resolution:  fixed
Keywords:  speech, audio  |        Game:  Sam and Max
--------------------------+----------------------------
Comment (by NMIError):

 In [changeset:"f828a6fdfb3b144dad08e92b18a811cb3abbdc9c" f828a6fd]:
 {{{#!CommitTicketReference repository=""
 revision="f828a6fdfb3b144dad08e92b18a811cb3abbdc9c"
 SCUMM: Fix excessive MIDI messages

 The code for reducing music volume levels during speech was sending out
 volume
 change messages every MIDI timer tick, regardless of whether the volume
 had
 actually changed. This caused problems for older MIDI hardware, which can
 only
 process a limited number of MIDI events in a given time period.

 Fixed this by checking if any of the volume levels set by
 musicVolumeReduction
 has actually changed before calling update_volumes. Looking at the MIDI
 output
 of the original interpreter, this also seems a better match to the
 original
 behavior.

 This fixes issue #15724.

 (cherry picked from commit fb7e7539d4ba735ea5ad30e189a6380d4874667e)
 }}}
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15724#comment:11>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM