[Scummvm-tracker] [ScummVM :: Bugs] #16421: HDB: Crash(?)/Exit when shooting the chicken

[ScummVM :: Bugs]

#16421: HDB: Crash(?)/Exit when shooting the chicken
--------------------+--------------------------------------
Reporter:  raziel-  |       Owner:  antoniou79
    Type:  defect   |      Status:  closed
Priority:  normal   |   Component:  Engine: HDB
 Version:           |  Resolution:  fixed
Keywords:           |        Game:  Hyperspace Delivery Boy
--------------------+--------------------------------------
Comment (by antoniou79):

 I started with the changes for supporting a basic save versioning system
 so that the new saved game version would support larger buffers for the
 dialog text. And I actually had a working build, but then I realized that
 at least for the cases where I'd seen the messages being truncated, they
 were truncated to 128 chars, and not to the 160 chars which is the full
 size of these text buffers.

 So I spotted in windows.cpp where this "truncation" is done (and there's a
 comment that seems relevant but not quite justified -- the comment says
 "This could need to be truncated"). Anyway, the relevant commit for that
 change was
 https://github.com/scummvm/scummvm/commit/16f1ff13bc8a123c691f2ec3c833c0bf696ed100
 and it looks to me that the 128 might have been by mistake due to the
 batch manner of changes in that commit.

 I've set the size to 160 now, and at least in the first map, the two cases
 that I was aware of text being truncated are now gone.
 The fix is in commit:
 https://github.com/scummvm/scummvm/commit/3ab926ef4f9a0657e9180b3eac66c3c3395f6561
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/16421#comment:12>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM