[Scummvm-tracker] [ScummVM :: Bugs] #16171: TOON: Cutscene subtitles not working

[ScummVM :: Bugs]

#16171: TOON: Cutscene subtitles not working
---------------------+---------------------------
Reporter:  danifs25  |       Owner:  (none)
    Type:  defect    |      Status:  new
Priority:  normal    |   Component:  Engine: Toon
 Version:            |  Resolution:
Keywords:            |        Game:  Toonstruck
---------------------+---------------------------
Comment (by eriktorbjorn):

 The problem seem to be that some (perhaps most?) videos are specified with
 a full name, and the subtitle player generates the subtitles filename from
 that. But SUBTITLES.PAK only stores the base name.

 It works in the intro, where only the base name (209_1M.SMK, etc.) are
 used. But for the cutifier, it's ACT2/DUNGEON/201DM.SMK

 Well, that can be easily fixed. Something like this, perhaps:

 {{{
 diff --git a/engines/toon/subtitles.cpp b/engines/toon/subtitles.cpp
 index 012d6e9a1db..ecce25d05d5 100644
 --- a/engines/toon/subtitles.cpp
 +++ b/engines/toon/subtitles.cpp
 @@ -82,7 +82,7 @@ bool SubtitleRenderer::load(const Common::Path &video) {
         Common::String ext("tss");
         subfile.replace(subfile.size() - ext.size(), ext.size(), ext);

 -       Common::ScopedPtr<Common::SeekableReadStream>
 subsStream(_vm->resources()->openFile(video.getParent().appendComponent(subfile)));
 +       Common::ScopedPtr<Common::SeekableReadStream>
 subsStream(_vm->resources()->openFile(Common::Path(subfile)));
         if (subsStream == nullptr) {
                 return false;
         }
 }}}

 Problem is, there are some weird characters in some subtitle lines. And I
 have no idea what that's about. Here's one example:

 [[Image(scummvm-toon-00000.png)]]
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/16171#comment:1>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM