[Scummvm-tracker] [ScummVM :: Bugs] #15177: SCI: LSL5: Drawing issues when using the "?" icon

[ScummVM :: Bugs]

#15177: SCI: LSL5: Drawing issues when using the "?" icon
-----------------------+-----------------------------------
Reporter:  antoniou79  |       Owner:  sluicebox
    Type:  defect      |      Status:  closed
Priority:  low         |   Component:  Engine: SCI
 Version:              |  Resolution:  wontfix
Keywords:  original    |        Game:  Leisure Suit Larry 5
-----------------------+-----------------------------------
Changes (by sluicebox):

 * keywords:   => original
 * owner:  (none) => sluicebox
 * resolution:   => wontfix
 * status:  new => closed

Comment:

 This script bug is original behavior in many SCI games, but it's beyond
 our ability to inline patch, and it's cosmetic. Closing as WONTFIX but
 it's really CANTFIX.

 The bug is in the `IconBar` system script and affects every game that uses
 the `NOCLICKHELP` feature, until Sierra fixed it cirica 1993. The event
 loop in `IconBar:noClickHelp` requires a call to `kAnimate(cast:elements)`
 to refresh the game area between dialogs. This was fixed in the CD version
 of Freddy Pharkas, and SQ5 fixed it with its own subclass. After that, the
 SCI32 versions called `kFrameOut`.

 Other games with the bug: LB2, QFG1VGA, QFG3, BRAIN1, BRAIN2, PEPPER, and
 the floppy version of Freddy Pharkas. In LB2, you can use it to reveal
 that a sarcophagus has a doorway behind it.

 Fixing this would require adding the missing call (12 bytes), but there's
 no room to do so, and even worse, the IconBar script evolved over the
 years so it would require a different patch for almost every game,
 sometimes per version. And who knows, maybe Sierra's fix doesn't work on
 the earlier games. Every part of this is beyond what we can do with inline
 patching.

 It's a good bug though, and if it could be reasonably patched I would. You
 can see Sierra's fix by comparing Freddy Pharkas floppy and CD scripts:

 https://github.com/sluicebox/sci-scripts/blob/main/fpfp-
 dos-1.0/src/IconBar.sc
 https://github.com/sluicebox/sci-scripts/blob/main/fpfp-cd-
 dos-1.0/src/IconBar.sc
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15177#comment:3>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM