[Scummvm-tracker] [ScummVM :: Bugs] #16211: ALL: Platform options seems to break GUI option parsing

[ScummVM :: Bugs]

#16211: ALL: Platform options seems to break GUI option parsing
-------------------------+---------------------
Reporter:  eriktorbjorn  |       Owner:  (none)
    Type:  defect        |      Status:  new
Priority:  normal        |   Component:  Common
 Version:                |  Resolution:
Keywords:                |        Game:
-------------------------+---------------------
Comment (by eriktorbjorn):

 Some more notes along the way.

 There is only one place where `parseGameGUIOptionsPlatforms()` is called,
 and that's from `parseGameGUIOptions()`. So we only need to worry about
 the latter, and fortunately that's not called in that many places either.

 Beneath a Steel Sky uses it to test for `GUIO_NOSPEECH` ("\x03"). This
 would potentially clash with `kPlatform3DO_VAL`, but by pure luck I don't
 think that's an issue.

 The SCUMM engine uses it to test for several things:

 - `GAMEOPTION_ORIGINALGUI` (`GUIO_GAMEOPTIONS4`)
 - `GAMEOPTION_COPY_PROTECTION` (`GUIO_GAMEOPTIONS7`)
 - `GAMEOPTION_ENHANCEMENTS` (`GUIO_GAMEOPTIONS2`)
 - `GAMEOPTION_LOWLATENCYAUDIO` (`GUIO_GAMEOPTIONS5`)
 - `GAMEOPTION_AUDIO_OVERRIDE` (`GUIO_GAMEOPTIONS3`)
 - `GAMEOPTION_REMASTERED_AUDIO` (`GUIO_GAMEOPTIONS8`)
 - `GAMEOPTION_TTS` (`GUIO_GAMEOPTIONS9`)
 - `GAMEOPTION_TRIM_FMTOWNS_TO_200_PIXELS` (`GUIO_GAMEOPTIONS1`)

 None of these can clash with the language options.

 The SCI engine does something with it, but only to append the language
 settings itself?

 So the main use is probably the options dialog, and I'll put that in a
 separate comment.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/16211#comment:1>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM