[Scummvm-tracker] [ScummVM :: Bugs] #16211: ALL: Platform options seems to break GUI option parsing

[ScummVM :: Bugs]

#16211: ALL: Platform options seems to break GUI option parsing
-------------------------+---------------------
Reporter:  eriktorbjorn  |       Owner:  (none)
    Type:  defect        |      Status:  new
Priority:  normal        |   Component:  Common
 Version:                |  Resolution:
Keywords:                |        Game:
-------------------------+---------------------
Comment (by eriktorbjorn):

 The options dialog checks for single flags:

 - `GUIO_NOASPECT` ("\x13"), possible clash with `kPlatformNES_VAL`
 - `GUIO_LINKMUSICTOSFX` ("\x31")
 - `GUIO_LINKSPEECHTOSFX` ("\x30")
 - `GUIO_MIDIADLIB` ("\x0a"), possible clash with `kPlatformDOS_VAL`
 - `GUIO_NOMIDI` ("\x05"), possible clash with `kPlatformAmiga_VAL`
 - `GUIO_NOMUSIC` ("\x02"), possible clash with `kPlatformApple2_VAL`
 - `GUIO_NOSFX` ("\x04"), possible clash with `kPlatformAcorn_VAL`
 - `GUIO_NOSPEECH` ("\x03"), possible clash with `kPlatform3DO_VAL`
 - `GUIO_NOSPEECHVOLUME` ("\x32")
 - `GUIO_NOSUBTITLES` ("\x01"), possible clash with `kPlatformApple2GS_VAL`

 It also checks for groups of flags:

 All MIDI flags:

 - `GUIO_MIDIPCSPK` ("\x07"), possible clash with `kPlatformAtariST_VAL`
 - `GUIO_MIDICMS` ("\x08"), possible clash with `kPlatformC64_VAL`
 - `GUIO_MIDIPCJR` ("\x09"), possible clash with `kPlatformAmstradCPC_VAL`
 - `GUIO_MIDIADLIB` ("\x0a"), possible clash with `kPlatformDOS_VAL`
 (possibly the source of the bug I initially saw)
 - `GUIO_MIDIC64` ("\x0b"), possible clash with `kPlatformPC98_VAL`
 - `GUIO_MIDIAMIGA` ("\x0c"), possible clash with `kPlatformWii_VAL`
 - `GUIO_MIDIAPPLEIIGS` ("\x0d"), possible clash with `kPlatformCoCo_VAL`
 - `GUIO_MIDITOWNS` ("\x0e"), possible clash with `kPlatformCoCo3_VAL`
 - `GUIO_MIDIPC98` ("\x0f"), possible clash with `kPlatformFMTowns_VAL`
 - `GUIO_MIDISEGACD` ("\x10"), possible clash with `kPlatformLinux_VAL`
 - `GUIO_MIDIGM` ("\x12"), possible clash with `kPlatformPCEngine_VAL`
 - `GUIO_MIDIMT32´ ("\x11"), possible clash with `kPlatformMacintosh_VAL`
 - `GUIO_MIDIMAC` ("\x17"), possible clash with `kPlatformPS2_VAL`

 Aside note: I would have thought that this would mean that a Macintosh SCI
 game would only offer MT-32 music, but that's not the case.

 All render modes:

 - `GUIO_RENDERHERCGREEN` ("\x18"), possible clash with `kPlatformPS3_VAL`
 - `GUIO_RENDERHERCAMBER` ("\x19"), possible clash with `kPlatformXbox_VAL`
 - `GUIO_RENDERCGA` ("\x1a"), possible clash with `kPlatformCDi_VAL`
 - `GUIO_RENDEREGA` ("\x1b"), possible clash with `kPlatformIOS_VAL`
 - `GUIO_RENDERVGA` ("\x1c"), possible clash with `kPlatformAndroid_VAL`
 - `GUIO_RENDERAMIGA` ("\x1d"), possible clash with `kPlatformOS2_VAL`
 - `GUIO_RENDERFMTOWNS` ("\x1e"), possible clash with `kPlatformBeOS_VAL`
 - `GUIO_RENDERPC98_256C` ("\x1f"), possible clash with
 `kPlatformPocketPC_VAL`
 - `GUIO_RENDERPC98_16C` ("\x20"), possible clash with
 `kPlatformMegaDrive_VAL`
 - `GUIO_RENDERAPPLE2GS` ("\x21"), possible clash with
 `kPlatformSaturn_VAL`
 - `GUIO_RENDERATARIST` ("\x22"), possible clash with `kPlatformPippin_VAL`
 - `GUIO_RENDERMACINTOSH` ("\x23"), possible clash with
 `kPlatformMacintoshII_VAL`
 - `GUIO_RENDERMACINTOSHBW` ("\x24"), possible clash with
 `kPlatformShockwave_VAL`
 - `GUIO_RENDERCGACOMP` ("\x25"), possible clash with `kPlatformZX_VAL`
 - `GUIO_RENDERCGABW` ("\x26"), possible clash with `kPlatformTI994_VAL`
 - `GUIO_RENDERPC` ("\x27"), possible clash with
 `kPlatformNintendoSwitch_VAL`
 - `GUIO_RENDERZX` ("\x28")
 - `GUIO_RENDERC64` ("\x29")
 - `GUIO_RENDERVGAGREY` ("\x2A")
 - `GUIO_RENDERPC98_8C`("\x2B")
 - `GUIO_RENDERWIN_16C` ("\x2D")
 - `GUIO_RENDERWIN_256C´ ("\x2C")

 Aside note: The `kRenderWin256c` and `kRenderWin16c` entries seem wrong in
 `s_renderGUIOMapping[]`?

 I do have one game for OS/2. I guess I should check if it incorrectly
 offers me Amiga rendering. Can't do it at the moment, though.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/16211#comment:2>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM