[Scummvm-tracker] [ScummVM :: Bugs] #17188: The Dig (Macintosh) crashes after R2D2 scream on Lucasarts animation logo after the ending credits

[ScummVM :: Bugs]

#17188: The Dig (Macintosh) crashes after R2D2 scream on Lucasarts animation logo
after the ending credits
----------------------------------+----------------------------
Reporter:  filipetolhuizen        |       Owner:  (none)
    Type:  defect                 |      Status:  new
Priority:  high                   |   Component:  Engine: SCUMM
 Version:                         |  Resolution:
Keywords:  The Dig Mac Macintosh  |        Game:  The Dig
----------------------------------+----------------------------
Comment (by fusefib):

 1) Why not both fixes?

 2) Well, yup, with the early debugger deletion alone, there might be
 another silly edge cleanup problem?
 - Delete the original debugger.
 - Set _debugger to nullptr.
 - Process events -> ctrl+alt+d -> allocate a new generic GUI::Debugger
 during the Quit confirmation.
 - Finish destroying Engine, without another delete _debugger.

 It might be better to move the existing g_engine reset before the event
 flush instead:

 {{{
 Engine::~Engine() {
         _mixer->stopAll();

         // The game-specific engine has already been torn down.
         // Stop exposing it before processing any remaining events.
         g_engine = nullptr;

         // Flush any pending remaining events
         Common::Event evt;
         while (g_system->getEventManager()->pollEvent(evt)) {}

         delete _debugger;
         delete _mainMenuDialog;

         // Remove our cursors again to prevent memory leaks
         CursorMan.popCursor();
         CursorMan.popCursorPalette();
 }
 }}}

 ...but I'm generally not sure what it might upset in various engines or
 the quit/return-to-launcher paths. I'll get back to you in a couple of
 years.

 Okay, I just wanted to quickly warn about the first thing, so I'll shut up
 now. ;)
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/17188#comment:7>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM