[Scummvm-devel] RTL branch to be merged (relevant for *all* developers)

[Filippos K]

> * Engine::go() returns the result of shouldRTL(), and this holds for all  
> engines. Why don't we
>    move this to the base code instead? I mean, the engine couldn't care  
> less if it's returning to
>    the launcher or quitting. The proper place for this check seems to be  
> scummvm_main, after the
>    engine has been shutdown and we are out of runGame. The meaning of the  
> return value for runGame
>    can be changed to: 0 if the engine couldn't start and 1 if the engine  
> started and shouldRTL must
>    be checked.

This seems like a more cleaner and transparent approach indeed
 
> And now, opinion's corner: speaking of general behaviour, after an engine  
> is shutdown it should
> always go back to the launcher. The only way for a direct quit should be  
> the GMM dialog. What do
> you guys think about this?

I agree on this, I believe it would be better if engines always return to launcher...

As for the engine features: I think that currently, most engines support these (i.e.
return to launcher, list saves etc), with some notable exceptions where save games
are completely handled by scripts. Wouldn't it be better semantically to change these
features the other way around, i.e. mark engines that do NOT support them? (e.g.
kSupportsRTL 		-> kDoesNotSupportRTL and so on)

Also, a question concerning AGI:
In cycle.cpp, the following line:
if (_game.quitProgNow == 0xff)
has been changed to:
if (quit() == 0xff)

This is the part where the game checks if it should be restarted or not
This seems a bit weird, as quitProgNow was an integer, but
quit() returns a boolean, so I'm unsure if this check will
ever be true. 
In the place where game.quitProgNow was set to 0xff, quitGame() is called instead
I'm thinking of changing the weird statement to "if (quit())",
but it still doesn't make sense for that part of the code :/

Regards
Filippos

_________________________________________________________________
Talk to your Yahoo! Friends via Windows Live Messenger.  Find out how.
http://www.windowslive.com/explore/messenger?ocid=TXT_TAGLM_WL_messenger_yahoo_082008
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20080902/5a4d955d/attachment.html>