[Scummvm-devel] Testing needed for GSoC OpenGL Branch

[Johannes Schickel]

On 09/03/2010 05:59 AM, vgvgf wrote:
> Hi all,
>
> Sorry for the late answer. I have committed some changes just a moment
> ago, fixing/improving some issues.
>
>    

I made some quick fix. Since the graphic managers didn't insert them 
into the event observer list automatically anymore, the mouse movement 
etc. was broken (or to be precise the displaying of that). I just added 
another call to initEventObserver in setGraphicsMode again to assure that.

What I found out while that, it seems unfortunate that I have to cast to 
the concrete type to do that. It feels odd since I guess all client code 
would need to do that anyway, thus why don't we add a interface method 
for that?

> Regarding the "Aspect Ratios", I have moved all of them to GFX modes
> (And removed previous x1, x2, x3 modes), as Johannes suggested. Then,
> I renamed all methods and related messages to "display modes" as yotam
> suggested. And also added the missing 4/3 mode with a Ctrl-Shift-A for
> going to previous mode.
>
>    

Actually I don't see why we should now have both Ctrl-Alt-A and 
Ctrl-Alt-1 etc. for changing the aspect mode. While it is true that 
formerly Ctrl-Alt-X was reserved for the display modes, it doesn't feel 
right to match them up to Ctrl-Alt-A too. I guess it would be best to 
just have Ctrl-Alt-A toggle the aspect ratio and maybe remove that from 
the mode list, so that it will behave just like the SDL backend in this 
case? Of course that would rather be contrary to the "Original" display 
mode...

> I also improved window resizing, so now when the window is resized
> while on "Conserve" or "4/3" modes, it will automatically maintain the
> aspect ratio. And, as Andre suggested I added automatically scaling
> when resizing, so if you are in x1 scale and resize the window to
> 700x600 it will scale to x2.
>
>    

What I currently dislike about how the window resizing behaves is that 
it doesn't work when I only resize it vertically (or horizontally). When 
I try that the window size does not change at all. I guess currently it 
always tries to fit the screen with the correct aspect into the window 
size the user requests.

Also IMHO when it's set to "Original" the window resizing should not be 
possible at all, unlike currently where you have the option to resize 
the window, but doing so will change nothing.

// Johannes