[Scummvm-devel] Contributing to ScummVM with an interpreter for Magnetic Scrolls?

[Paul Gilbert]

Oh, and I've made it a new sub-folder "magnetic2", and likewise a
"Magnetic2" namespace to differentiate it from the work already done on the
existing Magnetic sub-engine for Gargoyle.

Paul.

On Tue, May 7, 2019 at 4:33 PM Paul Gilbert <paulfgilbert at gmail.com> wrote:

> As Filippos mentioned, you create our own branch and work on that. As you
> requested, to get you going, I've created a new branch at
> http://github.com/dreammaster/scummvm.git called "magnetic". If you make
> your own branch for it, you'll find it already has detection entries added
> into it for the games, and everything hooked up and ready to go to call the
> runGame() method. Have at it. :)
>
> Paul.
>
> On Tue, May 7, 2019 at 8:14 AM Filippos Karapetis <bluegr at gmail.com>
> wrote:
>
>>
>>
>> On Mon, 6 May 2019 at 08:09, dettus <dettus at dettus.net> wrote:
>>
>>> ONE MORE QUESTION THOUGH:
>>>
>>> 4) What is the policy with rookie developers like me, in general? Should
>>> I just clone code from the git repository, commit/push/pull my changes? Or
>>> do you guys create a branch? And merge the code over after a reviewing
>>> process or something?
>>>
>>
>> You work in a separate branch, and when you feel that your code is mature
>> enough, create a pull request, so that your code can get reviewed and merged
>>
>> Regards
>> Filippos
>>
>> --
>> "Experience is the name every one gives to their mistakes" - Oscar Wilde
>> _______________________________________________
>> Scummvm-devel mailing list
>> Scummvm-devel at lists.scummvm.org
>> https://lists.scummvm.org/listinfo/scummvm-devel
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20190507/26a35828/attachment.html>