[Scummvm-git-logs] scummvm master -> becf1b1fd64217d1139c490fa8645d44dd684a12

neuromancer noreply at scummvm.org
Sat May 7 10:18:14 UTC 2022


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
becf1b1fd6 HYPNO: improved format string security when displaying errors in wet


Commit: becf1b1fd64217d1139c490fa8645d44dd684a12
    https://github.com/scummvm/scummvm/commit/becf1b1fd64217d1139c490fa8645d44dd684a12
Author: neuromancer (gustavo.grieco at gmail.com)
Date: 2022-05-07T12:18:38+02:00

Commit Message:
HYPNO: improved format string security when displaying errors in wet

Changed paths:
    engines/hypno/wet/wet.cpp


diff --git a/engines/hypno/wet/wet.cpp b/engines/hypno/wet/wet.cpp
index b3e7619c4f7..ae559e9de83 100644
--- a/engines/hypno/wet/wet.cpp
+++ b/engines/hypno/wet/wet.cpp
@@ -112,7 +112,7 @@ void WetEngine::loadAssetsDemoDisc() {
 	LibFile *missions = loadLib("", "wetlands/c_misc/missions.lib", encrypted);
 	Common::ArchiveMemberList files;
 	if (missions->listMembers(files) == 0)
-		error(failedDetectionError);
+		error("%s", failedDetectionError);
 
 	Hotspot h(MakeMenu);
 	Hotspots hs;
@@ -211,7 +211,7 @@ void WetEngine::loadAssetsGen4() {
 	LibFile *missions = loadLib("", "c_misc/missions.lib", encrypted);
 	Common::ArchiveMemberList files;
 	if (missions->listMembers(files) == 0)
-		error(failedDetectionError);
+		error("%s", failedDetectionError);
 
 	Transition *intro;
 	intro = new Transition("c31.mis");
@@ -288,7 +288,7 @@ void WetEngine::loadAssetsPCW() {
 	LibFile *missions = loadLib("", "c_misc/missions.lib", false);
 	Common::ArchiveMemberList files;
 	if (missions->listMembers(files) == 0)
-		error(failedDetectionError);
+		error("%s", failedDetectionError);
 
 	Transition *intro = new Transition("c11.mis");
 	intro->intros.push_back("c_misc/nw_logo.smk");
@@ -312,7 +312,7 @@ void WetEngine::loadAssetsPCG() {
 	LibFile *missions = loadLib("", "missions.lib", false);
 	Common::ArchiveMemberList files;
 	if (missions->listMembers(files) == 0)
-		error(failedDetectionError);
+		error("%s", failedDetectionError);
 
 	Transition *intro = new Transition("c31.mis");
 	intro->intros.push_back("nw_logo.smk");
@@ -338,7 +338,7 @@ void WetEngine::loadAssetsFullGame() {
 	LibFile *missions = loadLib("", "c_misc/missions.lib", true);
 	Common::ArchiveMemberList files;
 	if (missions == nullptr || missions->listMembers(files) == 0)
-		error(failedDetectionError);
+		error("%s", failedDetectionError);
 
 	Transition *logos = new Transition("<main_menu>");
 	logos->intros.push_back("c_misc/logo.smk");




More information about the Scummvm-git-logs mailing list