[Scummvm-git-logs] scummvm master -> 44ad305cbe312cd0999ca965bae8bcee0ce9fcf4

[criezy]

This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
e8ebf8800c MACOS: Add Application Category Type key in Info,plist
44ad305cbe MACOS: Remove Sparkle XPC Services when creating the app bundle


Commit: e8ebf8800c414184fa09f30b03b56537cf87c155
    https://github.com/scummvm/scummvm/commit/e8ebf8800c414184fa09f30b03b56537cf87c155
Author: Thierry Crozat (criezy at scummvm.org)
Date: 2024-01-15T23:05:14Z

Commit Message:
MACOS: Add Application Category Type key in Info,plist

This will be needed if we ever decide to submit the app to the Mac
App Store.

Changed paths:
    dists/macosx/Info.plist
    dists/macosx/Info.plist.in


diff --git a/dists/macosx/Info.plist b/dists/macosx/Info.plist
index fd7c7defbd4..225cb7b60b2 100644
--- a/dists/macosx/Info.plist
+++ b/dists/macosx/Info.plist
@@ -32,6 +32,8 @@
 	<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
+	<key>LSApplicationCategoryType</key>
+	<string>public.app-category.adventure-games</string>
 	<key>CFBundleLocalizations</key>
 	<array>
 		<string>en</string>
diff --git a/dists/macosx/Info.plist.in b/dists/macosx/Info.plist.in
index 4d57c7b235b..c05f0e0a853 100644
--- a/dists/macosx/Info.plist.in
+++ b/dists/macosx/Info.plist.in
@@ -32,6 +32,8 @@
 	<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
+	<key>LSApplicationCategoryType</key>
+	<string>public.app-category.adventure-games</string>
 	<key>CFBundleLocalizations</key>
 	<array>
 		<string>en</string>


Commit: 44ad305cbe312cd0999ca965bae8bcee0ce9fcf4
    https://github.com/scummvm/scummvm/commit/44ad305cbe312cd0999ca965bae8bcee0ce9fcf4
Author: Thierry Crozat (criezy at scummvm.org)
Date: 2024-01-15T23:07:31Z

Commit Message:
MACOS: Remove Sparkle XPC Services when creating the app bundle

The XPC Services are only needed for sandboxed app. Sandboxing the
ScummVM App will be required if we submit it to the Mac App Store,
but since the Mac App Store handles app updates we have no reason
to use Sparkle for that version. So assume we will only use Sparkle
in non-sandboxed applications.

If we find that we need to keep the XPC Services, we will need to
update how the bundle is signed. With the current commands this
results in a corrupted bundle that cannot be open.
See https://sparkle-project.org/documentation/sandboxing/#code-signing

Changed paths:
    ports.mk


diff --git a/ports.mk b/ports.mk
index 085090c4313..854ee2013fd 100644
--- a/ports.mk
+++ b/ports.mk
@@ -146,6 +146,8 @@ ifdef USE_SPARKLE
 	cp $(srcdir)/dists/macosx/dsa_pub.pem $(bundle_name)/Contents/Resources/
 	rm -rf $(bundle_name)/Contents/Frameworks/Sparkle.framework
 	cp -RP $(SPARKLEPATH)/Sparkle.framework $(bundle_name)/Contents/Frameworks/
+	rm -f $(bundle_name)/Contents/Frameworks/Sparkle.framework/XPCServices
+	rm -rf $(bundle_name)/Contents/Frameworks/Sparkle.framework/Versions/Current/XPCServices/
 endif
 ifdef MACOSX_LEOPARD_OR_BELOW
 	cp $(srcdir)/icons/scummvm_legacy.icns $(bundle_name)/Contents/Resources/scummvm.icns