[ scummvm-Bugs-996674 ] SmushPlayer can crash while using threaded timer

[SourceForge.net]

Bugs item #996674, was opened at 2004-07-23 19:08
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=996674&group_id=37116

Category: Insane/Smush
Group: All Games
Status: Open
Resolution: None
Priority: 5
Submitted By: Uwe Ryssel (uweryssel)
Assigned to: Eugene Sandulenko (sev)
Summary: SmushPlayer can crash while using threaded timer

Initial Comment:
The SmushPlayer class isn't secure,
while using a threaded timer.

When the SmushPlayer object is destructed
it can be happen that the timer callback
is still running, because the callback is
launched by another thread.

Removing the callback in the destructor
can't remove the problem, because it only
prevents new callback runs and not stop
the current one.

My solution is to wait 500ms after the
removeTimerProc, so all running callbacks
can be processed.
But this is not the best solution.

I've seen the same bug in IMuseDigital class too.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=996674&group_id=37116