[Scummvm-tracker] [ScummVM :: Bugs] #15165: Leisure Suit Larry 6 Freeze during Electric Shock cutscene

[ScummVM :: Bugs]

#15165: Leisure Suit Larry 6 Freeze during Electric Shock cutscene
--------------------------+-----------------------------------
Reporter:  tacoadventure  |       Owner:  sluicebox
    Type:  defect         |      Status:  closed
Priority:  normal         |   Component:  Engine: SCI
 Version:                 |  Resolution:  fixed
Keywords:                 |        Game:  Leisure Suit Larry 6
--------------------------+-----------------------------------
Changes (by sluicebox):

 * owner:  (none) => sluicebox
 * resolution:   => fixed
 * status:  new => closed

Comment:

 The freeze is fixed. It was due to engine inaccuracies I noticed two years
 ago when investigating a more difficult audio bug in Dagger of Amon Ra; it
 was too difficult for me to complete. I found my notes, implemented some
 of my findings, and now the freeze is fixed and the Dagger scene is
 slightly better.

 The scene isn't perfectly accurate yet: in the original you hear *clip*
 "Ow!" *clip* and in ScummVM you will only here "Ow!" *clip*. That's
 because the original only worked by accident: it plays the first *clip*
 sound and then on the next line of script, plays "Ow!" which stops the
 previous sound and plays the new one, because SCI16 can only play one
 digital audio at a time. And yet, it appears to work in the original.
 That's because, and I think this is a new finding, when the SCI16 audio
 driver interrupts one sound with another, a very short amount of the first
 sound still ends up playing. I replaced the *clip* sounds with much longer
 sounds to verify this. The *clip* sound is so short that it manages to
 completely play, and so this scripting mistake went unnoticed until the
 SCI32 port when their luck ran out and they rewrote this script to be
 normal.

 I don't know if or when we will ever figure out and implement this obscure
 interruption behavior. With each of these changes though, we get closer to
 original accuracy.

 There's another inaccuracy in this scene, but it happens to be beneficial:
 when Chardonnay enters the room, the original would cut off her speech
 when the door-close sound played. For some reason we are not interrupting
 that and both sounds play; I think that's another inaccuracy I noted two
 years ago. But for now, that's good, because you can hear her speech which
 you couldn't in the original.

 Thanks again for reporting this! But yeesh why couldn't it have been
 another scene... =O

 For reference, here's the original behavior:
 https://youtu.be/VINuOmJH1_I?t=9813
 And here's the script that plays a digital sample and speech at the same
 time: https://github.com/sluicebox/sci-
 scripts/blob/65c4100d1ba073e89290554f51acbe78777e3c95/lsl6-cd-
 dos-1.000.000/src/rm380.sc#L535
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15165#comment:15>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM