[Scummvm-devel] Dropping MPEG2 code?

[Filippos K]

I've also made a patch that completely removes MPEG2 playing, and I've rewritten all the BS1 video playing code to the new video player code. The resulting file is about 6-8kb big, and the code is much much much more simplified. As eriktorbjorn said, a lot of the code is simplified (especially for BS1). It is able to play both DXA and Smacker movies without any code
duplication. It also throws a nice error message if it finds MPEG2
cutscenes. I don't have it handy right now, but I can upload it in the
evening. Also, a whole big class is removed (the credits playing code), as it's only used for version 1 MPEG2 files. The credits in BS1 are in Smacker format anyway, but I believe that the credits player was added because the credits themselves were unreadable in MPEG2 encoded files.

I was reluctant to upload it, as I wasn't sure about the status of the Smacker movies in the BS games, but since joostp got the OK from the Revolution guys, I guess we could add Smacker support to the videos of BS1/BS2?

Regards
Filippos Karapetis

> Date: Sun, 11 Jan 2009 19:18:52 +0100
> From: eriktorbjorn at telia.com
> To: scummvm-devel at lists.sourceforge.net
> Subject: Re: [Scummvm-devel] Dropping MPEG2 code?
> 
> Max Horn wrote:
> 
> > That's exactly how I would want it to be done :). Volunteers?
> 
> The restructuring that was made when adding support for DXA cutscenes
> makes it quite straightforward to remove the MPEG support from Broken
> Sword 1/2:
> 
> http://www.update.uu.se/~d91tan/ScummVM/mpeg2-removal.txt
> 
> (That's a diff against current SVN.)
> 
> Actually, for Broken Sword 1 you could probably go even further. There
> is support for some more advanced cutscene packs. I think the idea was
> to make language-independent cutscene packs, but I never added support
> for the video part of them to the DXA player, because I wasn't (and
> still isn't) convinced that they even exist.
> 
> If you remove the remaining traces of them, starting with the
> cutscenePackVersion variable from the SystemVars struct, you would also
> lose the SplittedAudioStream class from animation.h, and most (all?) of
> credits.cpp.
> 
> But maybe I've been wrong all along, and the advanced cutscene packs
> really do exist...?
> 
> Torbjörn Andersson
> 
> ------------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It is the best place to buy or sell services for
> just about anything Open Source.
> http://p.sf.net/sfu/Xq1LFB
> _______________________________________________
> Scummvm-devel mailing list
> Scummvm-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/scummvm-devel

_________________________________________________________________
Windows Live™ Hotmail®: Chat. Store. Share. Do more with mail. 
http://windowslive.com/explore?ocid=TXT_TAGLM_WL_t1_hm_justgotbetter_explore_012009
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20090112/1ec9b56d/attachment.html>